Page MenuHomePhabricator

Fix `arc diff --raw` when run outside a repository
ClosedPublic

Authored by epriestley on May 15 2014, 8:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 12:56 PM
Unknown Object (File)
Sun, Feb 9, 12:56 PM
Unknown Object (File)
Sun, Feb 9, 12:56 PM
Unknown Object (File)
Sun, Feb 9, 12:56 PM
Unknown Object (File)
Sun, Feb 2, 6:53 PM
Unknown Object (File)
Thu, Jan 30, 9:14 AM
Unknown Object (File)
Sat, Jan 25, 2:49 AM
Unknown Object (File)
Sat, Jan 25, 2:38 AM
Subscribers

Details

Summary

Fixes T5071. If you run arc diff --raw from some arbitrary, non-repository directory we incorrectly try to read information out of the working copy. Even if this information is available, arc diff --raw should not assume it's accurate (there's no guarantee the diff comes from the working copy).

Test Plan

Ran arc diff --raw in an arbitrary directory.

Diff Detail

Repository
rARC Arcanist
Branch
rawrepo
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 493
Build 493: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix `arc diff --raw` when run outside a repository.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 16 2014, 2:02 AM
epriestley updated this revision to Diff 21721.

Closed by commit rARC75cb3cf35819 (authored by @epriestley).