Page MenuHomePhabricator

Fix `arc diff --raw` when run outside a repository
ClosedPublic

Authored by epriestley on May 15 2014, 8:46 PM.
Tags
None
Referenced Files
F14027252: D9142.diff
Fri, Nov 8, 6:04 AM
F14015894: D9142.id21711.diff
Mon, Nov 4, 2:19 AM
F13992094: D9142.diff
Tue, Oct 22, 2:18 PM
F13973273: D9142.diff
Fri, Oct 18, 12:10 AM
F13959948: D9142.diff
Mon, Oct 14, 9:27 PM
Unknown Object (File)
Sat, Oct 12, 4:52 AM
Unknown Object (File)
Oct 10 2024, 8:43 AM
Unknown Object (File)
Sep 27 2024, 5:55 PM
Subscribers

Details

Summary

Fixes T5071. If you run arc diff --raw from some arbitrary, non-repository directory we incorrectly try to read information out of the working copy. Even if this information is available, arc diff --raw should not assume it's accurate (there's no guarantee the diff comes from the working copy).

Test Plan

Ran arc diff --raw in an arbitrary directory.

Diff Detail

Repository
rARC Arcanist
Branch
rawrepo
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 493
Build 493: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix `arc diff --raw` when run outside a repository.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 16 2014, 2:02 AM
epriestley updated this revision to Diff 21721.

Closed by commit rARC75cb3cf35819 (authored by @epriestley).