Page MenuHomePhabricator
Differential D9127

When a conduit method requires a string constant, call it "string-const" not "enum"
ClosedPublic
Actions

Authored by epriestley on May 15 2014, 12:43 AM.
Tags
None
Referenced Files
F14489791: D9127.diff
Thu, Jan 2, 12:46 AM
Unknown Object (File)
Thu, Dec 26, 2:36 PM
Unknown Object (File)
Thu, Dec 26, 6:14 AM
Unknown Object (File)
Mon, Dec 23, 9:49 AM
Unknown Object (File)
Mon, Dec 23, 9:49 AM
Unknown Object (File)
Mon, Dec 23, 9:49 AM
Unknown Object (File)
Mon, Dec 23, 4:37 AM
Unknown Object (File)
Tue, Dec 17, 10:59 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T5058: Improve diagnostics around waiting targets in Harbormaster
Commits
Restricted Diffusion Commit
rP15561a27c31f: When a conduit method requires a string constant, call it "string-const" not…
Summary

Ref T5058. The use of "enum" is confusing; we mean "choose one of these specific string constants". Make this more clear.

Test Plan

Viewed each call from the web UI.

Diff Detail

Repository
rP Phabricator
Branch
stringconst
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 472
Build 472: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21683.May 15 2014, 12:43 AM
epriestley retitled this revision from to When a conduit method requires a string constant, call it "string-const" not "enum".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5058: Improve diagnostics around waiting targets in Harbormaster.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 15 2014, 12:43 AM
Harbormaster completed remote builds in B472: Diff 21683.May 15 2014, 12:44 AM
btrahan accepted this revision.May 15 2014, 2:47 AM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 15 2014, 2:47 AM
epriestley closed this revision.May 15 2014, 4:59 AM
epriestley updated this revision to Diff 21686.

Closed by commit rP15561a27c31f (authored by @epriestley).

Revision Contents
Changeset List

Diff 21683

View Options

src/applications/audit/conduit/ConduitAPI_audit_query_Method.php

Loading...
View Options

src/applications/conduit/method/ConduitAPIMethod.php

Loading...
View Options

src/applications/differential/conduit/ConduitAPI_differential_creatediff_Method.php

Loading...
View Options

src/applications/differential/conduit/ConduitAPI_differential_find_Method.php

Loading...
View Options

src/applications/differential/conduit/ConduitAPI_differential_getcommitmessage_Method.php

Loading...
View Options

src/applications/differential/conduit/ConduitAPI_differential_query_Method.php

Loading...
View Options

src/applications/harbormaster/conduit/ConduitAPI_harbormaster_sendmessage_Method.php

Loading...
View Options

src/applications/maniphest/conduit/ConduitAPI_maniphest_query_Method.php

Loading...
View Options

src/applications/people/conduit/ConduitAPI_user_addstatus_Method.php

Loading...
View Options

src/applications/project/conduit/ConduitAPI_project_query_Method.php

Loading...
View Options

src/applications/releeph/conduit/work/ConduitAPI_releephwork_getcommitmessage_Method.php

Loading...
View Options

src/applications/releeph/conduit/work/ConduitAPI_releephwork_record_Method.php

Loading...
View Options

src/applications/releeph/conduit/work/ConduitAPI_releephwork_recordpickstatus_Method.php

Loading...
View Options

src/applications/remarkup/conduit/ConduitAPI_remarkup_process_Method.php

Loading...
View Options

src/applications/repository/conduit/ConduitAPI_repository_create_Method.php

Loading...
Phabricator · Built by Phacility