Page MenuHomePhabricator
Differential D9123

If PhabricatorIRCBot encounters a 'nick used' error, try adding a number
ClosedPublic
Actions

Authored by Firehed on May 14 2014, 6:09 PM.
Tags
None
Referenced Files
F13175966: D9123.diff
Wed, May 8, 9:14 AM
Unknown Object (File)
Tue, May 7, 5:13 AM
Unknown Object (File)
Mon, May 6, 5:39 PM
Unknown Object (File)
Fri, May 3, 2:38 AM
Unknown Object (File)
Thu, May 2, 9:02 AM
Unknown Object (File)
Tue, Apr 30, 3:01 PM
Unknown Object (File)
Mon, Apr 29, 2:07 PM
Unknown Object (File)
Mon, Apr 29, 11:07 AM
View All Files
Subscribers
epriestley
Korvin
WePay

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP358b59ffa784: If PhabricatorIRCBot encounters a 'nick used' error, try adding a number
Summary

Someone stole my bot's name, so the bot couldn't (re)connect. This tries adding some text to the name if it encounters a 433 'nick in use' error

Test Plan

Started a ton of bots: F154744

Diff Detail

Repository
rP Phabricator
Branch
phabot
Lint
Lint Skipped
Unit
Tests Passed
Build Status
Buildable 466
Build 466: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

Firehed updated this revision to Diff 21671.May 14 2014, 6:09 PM
Firehed retitled this revision from to If PhabricatorIRCBot encounters a 'nick used' error, try adding a number.
Firehed updated this object.
Firehed edited the test plan for this revision. (Show Details)
Firehed added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 14 2014, 6:09 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B466: Diff 21671.May 14 2014, 6:10 PM
epriestley accepted this revision.May 14 2014, 6:21 PM
epriestley edited edge metadata.

Scoundrels!

This revision is now accepted and ready to land.May 14 2014, 6:21 PM
Firehed added a comment.May 14 2014, 10:29 PM

(I don't have push access - need you to land this)

epriestley added a comment.May 14 2014, 10:29 PM

Sorry, yeah -- I think this hung on a non-fastforward and then I had a meeting. Let me kick it again...

epriestley closed this revision.May 14 2014, 10:30 PM
epriestley updated this revision to Diff 21675.
epriestley added a subscriber: WePay.

Closed by commit rP358b59ffa784 (authored by @WePay, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
infrastructure/
daemon/
bot/
adapter/
8 lines

Diff 21671

View Options

src/infrastructure/daemon/bot/adapter/PhabricatorIRCProtocolAdapter.php

Loading...
Phabricator · Built by Phacility