Differential D9123

If PhabricatorIRCBot encounters a 'nick used' error, try adding a number
ClosedPublic
Actions

Authored by Firehed on May 14 2014, 6:09 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP358b59ffa784: If PhabricatorIRCBot encounters a 'nick used' error, try adding a number

Summary

Someone stole my bot's name, so the bot couldn't (re)connect. This tries adding some text to the name if it encounters a 433 'nick in use' error

Test Plan

Started a ton of bots: F154744

Diff Detail

Repository

rP Phabricator

Branch

phabot

Lint

Lint Skipped

Unit

Tests Passed

Build Status

Buildable 466
Build 466: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

Firehed updated this revision to Diff 21671.May 14 2014, 6:09 PM

Firehed retitled this revision from to If PhabricatorIRCBot encounters a 'nick used' error, try adding a number.

Firehed updated this object.

Firehed edited the test plan for this revision. (Show Details)

Firehed added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 14 2014, 6:09 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B466: Diff 21671.May 14 2014, 6:10 PM

Scoundrels!

This revision is now accepted and ready to land.May 14 2014, 6:21 PM

(I don't have push access - need you to land this)

Sorry, yeah -- I think this hung on a non-fastforward and then I had a meeting. Let me kick it again...

Closed by commit rP358b59ffa784 (authored by @WePay, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

daemon/

bot/

adapter/

PhabricatorIRCProtocolAdapter.php

8 lines

Diff 21671

View Options

src/infrastructure/daemon/bot/adapter/PhabricatorIRCProtocolAdapter.php

If PhabricatorIRCBot encounters a 'nick used' error, try adding a numberClosedPublicActions