This fixes an issue with the C# linter where a message could be returned from cslint that wasn't intended for use with parameters. This just ensures there's enough parameters so that it won't crash (and consequently ignore lint messages).
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARCfcdacc28b8a2: Fix issue where message contained % but wasn't intended for use with parameters
Ran the linter, it didn't crash.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- master
- Lint
Lint Skipped - Unit
Test Failures - Build Status
Buildable 456 Build 456: [Placeholder Plan] Wait for 30 Seconds
| Time | Test | |
|---|---|---|
| 0 ms | testCSSLintLinter | |
| 0 ms | testPEP8Linter | |
| 0 ms | testPHPCSLint | |
| 0 ms | testSpellingLint | |
| 0 ms | testXHPASTLint | |
| View Full Test Results (5 Failed · 4 Passed · 9 Skipped) |
Event Timeline
Comment Actions
Is the "crash" a vsprintf() error raising into an exception? Can we do something like this instead?
$message = @vsprintf($pattern, ...);
if ($message === false) {
$message = $pattern;
}That will get a bunch of (probably hypothetical) cases right that this misses, I think.