Make phrasing on "Mark All Read" consistent
ClosedPublic
Actions

Authored by epriestley on May 12 2014, 12:21 PM.

Tags

None

Referenced Files

	F16609613: D9073.id21553.diff
	Tue, Jun 17, 7:21 AM

	F16588379: D9073.id21548.diff
	Tue, Jun 17, 5:13 AM

	F16528975: D9073.diff
	Mon, Jun 16, 10:45 PM

	Unknown Object (File)
	Sat, May 31, 12:39 AM

	Unknown Object (File)
	Sat, May 31, 12:39 AM

	Unknown Object (File)
	Sun, May 25, 6:09 PM

	Unknown Object (File)
	Tue, May 20, 4:41 AM

	Unknown Object (File)
	Tue, May 20, 12:28 AM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan
chad

Maniphest Tasks

T5025: Potentially ambiguous "Clear all notifications" option in Notifications popup

Commits

Restricted Diffusion Commit
rP1687ffcd9e1d: Make phrasing on "Mark All Read" consistent

Summary

Fixes T5025. We label this action in two different ways ("Clear All Notifications", "Mark All Read"). The latter is probably a better description.

Test Plan

looked at the UI.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21548.May 12 2014, 12:21 PM

epriestley retitled this revision from to Make phrasing on "Mark All Read" consistent.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

epriestley added a task: T5025: Potentially ambiguous "Clear all notifications" option in Notifications popup.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 12 2014, 12:21 PM

Harbormaster completed remote builds in B396: Diff 21548.May 12 2014, 12:22 PM

plustwo

This revision is now accepted and ready to land.May 12 2014, 2:18 PM

Closed by commit rP1687ffcd9e1d (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

notification/

controller/

PhabricatorNotificationPanelController.php

2 lines

Diff 21553

View Options

src/applications/notification/controller/PhabricatorNotificationPanelController.php

Make phrasing on "Mark All Read" consistentClosedPublicActions