Page MenuHomePhabricator
Differential D9067

Remove the `getConfig` and `setConfig` method.
ClosedPublic
Actions

Authored by joshuaspence on May 12 2014, 4:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 23, 8:15 AM
Unknown Object (File)
Mon, Dec 23, 8:15 AM
Unknown Object (File)
Thu, Dec 19, 1:04 AM
Unknown Object (File)
Tue, Dec 17, 6:19 AM
Unknown Object (File)
Mon, Dec 9, 1:53 AM
Unknown Object (File)
Sat, Dec 7, 11:44 AM
Unknown Object (File)
Fri, Dec 6, 2:50 AM
Unknown Object (File)
Sun, Dec 1, 6:52 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCbe803ce5777c: Remove the `getConfig` and `setConfig` method.
Summary

It seems that there is a lot of overlap between getConfig / setConfig and getLinterConfigurationOptions / setLinterConfigurationValue respectively.

Test Plan

arc lint and arc unit.

Diff Detail

Repository
rARC Arcanist
Branch
getConfig
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 387
Build 387: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 21531.May 12 2014, 4:00 AM
joshuaspence retitled this revision from to Remove the `getConfig` and `setConfig` method..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 12 2014, 4:00 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B387: Diff 21531.May 12 2014, 4:01 AM
epriestley closed this revision.May 12 2014, 11:47 AM
epriestley updated this revision to Diff 21541.
epriestley edited edge metadata.

Closed by commit rARCbe803ce5777c (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
lint/
engine/
2 lines
linter/
22 lines
10 lines
38 lines
__tests__/
5 lines
xhpast/
2 lines

Diff 21531

View Options

src/lint/engine/ComprehensiveLintEngine.php

Loading...
View Options

src/lint/linter/ArcanistLesscLinter.php

Loading...
View Options

src/lint/linter/ArcanistLinter.php

Loading...
View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/switches.lint-test

Loading...
Phabricator · Built by Phacility