The ArcanistGeneratedLinter and ArcanistNoLintLinter don't actually ever raise any linter messages, so it doesn't make sense to set custom severities for these linters. Instead, don't expose this configuration.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARC9bd740b1f85c: Remove severity options from some linters.
N/A
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- linter-no-options
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 377 Build 377: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
There may be a benefit in providing a more general solution, such as a canCustomizeLintSeverities method.
In some of the external linters that I have added recently, the expectation is that you use some sort of configuration file to customize rules and severities rather than customizing with .arclint. There are two reasons for this
- To retain compatibility when the linting tool is used without arc.
- So that we don't have to care about (and keep up to date with) all of the rules that the external linter understands.
Possibly it may even be true to say that for all external linters we shouldn't provide custom severities.
Comment Actions
Possibly it may even be true to say that for all external linters we shouldn't provide custom severities.
I this this probably overreaches -- it's very common for users to want to customize flake8 messages, for example. T4287 has some discussion.
I'm onboard with canCustomizeLintSeverities(), though. Let's do that?
Comment Actions
Again, this was tested in the arclint-examples repo by just changing some stuff and then running arc lint`.
Comment Actions
Closed by commit rARC9bd740b1f85c (authored by @joshuaspence, committed by @epriestley).