Currently, paths to be excluded from linting need to be specified for each linter individually. This is a pain for projects that are using even a moderate number of linters and which have common paths which should be excluded from linting completely.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- rARCc4985ef41556: Allow global excludes to be specified in `.arclint`.
Unfortunately, it's hard to test this sort of stuff. I cloned the arclint-examples repository and tested my changes there,
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- arclint-global_excludes
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 366 Build 366: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/lint/engine/ArcanistConfigurationDrivenLintEngine.php | ||
|---|---|---|
| 28 | We added regex to PhutilTypeSpec a while ago -- in the existing case you get a more detailed error from validateRegexps() than checkMap() can raise, but the two errors might have similar usefulness here. I'll just pull this for now and we can evaluate cleaning it up later, I'd like to tune the per-linter errors to make them easier to figure out anyway. | |
Comment Actions
Closed by commit rARCc4985ef41556 (authored by @joshuaspence, committed by @epriestley).