Page MenuHomePhabricator

Slightly reduce the cost of resolving refs
ClosedPublic

Authored by epriestley on May 11 2014, 12:46 AM.
Tags
None
Referenced Files
F13281576: D9048.diff
Sun, Jun 2, 10:57 AM
F13258871: D9048.id.diff
Sun, May 26, 1:36 PM
F13243110: D9048.diff
Thu, May 23, 3:22 AM
F13220957: D9048.diff
Sun, May 19, 2:09 AM
F13202958: D9048.diff
Tue, May 14, 11:21 PM
F13187619: D9048.diff
Sat, May 11, 4:39 AM
Unknown Object (File)
Tue, May 7, 6:54 AM
Unknown Object (File)
May 3 2024, 5:37 AM
Subscribers

Details

Summary

Ref T2683. By resolving the stable name earlier, we can save a resolve when viewing branch heads. This is ~100ms in Mercurial, and roughly 25% of page weight. It's less bad in Git.

Test Plan

Saw page cost go down in "Services" tab, particularly for Mercurial browse views.

Diff Detail

Repository
rP Phabricator
Branch
gcache8
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 357
Build 357: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Slightly reduce the cost of resolving refs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 12 2014, 6:28 PM
epriestley updated this revision to Diff 21573.

Closed by commit rP53e9df8a0282 (authored by @epriestley).