Add `--quiet` flags to the `ArcanistCSSLintLinter`.
ClosedPublic
Actions

Authored by joshuaspence on May 10 2014, 5:47 AM.

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Commits

rARC89de113787af: Add `--quiet` flags to the `ArcanistCSSLintLinter`.

Summary

This isn't really necessary, nor does it bear any significant benefits, however semantically it seems to make sense. From csslint --help, the --quiet flag causes csslint to "Only output when errors are present".

Test Plan

Tested using csslint directly:

> csslint test.css


csslint: No errors in /home/joshua/workspace/github.com/facebook/arcanist/foo.css.
> csslint --quiet test.css

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 21461.May 10 2014, 5:47 AM

joshuaspence retitled this revision from to Add `--quiet` flags to the `ArcanistCSSLintLinter`..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added reviewers: Blessed Reviewers, chad. · View Herald TranscriptMay 10 2014, 5:47 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B339: Diff 21461.May 10 2014, 5:48 AM

epriestley accepted this revision.May 10 2014, 8:52 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 10 2014, 8:52 AM

Closed by commit rARC89de113787af (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistCSSLintLinter.php

5 lines

Diff 21469

View Options

src/lint/linter/ArcanistCSSLintLinter.php

Add `--quiet` flags to the `ArcanistCSSLintLinter`.ClosedPublicActions