Paths

Table of Contentst

Use PHP type hinting in `ArcanistXHPASTLinter`.
ClosedPublic
Actions

Authored by joshuaspence on May 10 2014, 7:44 AM.

Tags

None

Referenced Files

	F14006606: D9040.id21465.diff
	Mon, Oct 28, 2:04 PM

	F13989989: D9040.id.diff
	Tue, Oct 22, 12:18 AM

	F13989988: D9040.id21472.diff
	Tue, Oct 22, 12:18 AM

	F13989987: D9040.id21465.diff
	Tue, Oct 22, 12:18 AM

	F13989777: D9040.diff
	Mon, Oct 21, 10:59 PM

	F13972250: D9040.diff
	Thu, Oct 17, 5:58 PM

	F13972240: D9040.id.diff
	Thu, Oct 17, 5:55 PM

	F13972237: D9040.id21465.diff
	Thu, Oct 17, 5:54 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC20a05595226c: Use PHP type hinting in `ArcanistXHPASTLinter`.

Summary

Explicitly specify the types of the function parameters. This change is basically the same as D8388.

Test Plan

arc unit.

Diff Detail

Repository

rARC Arcanist

Branch

xhpast

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 343
Build 343: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 21465.May 10 2014, 7:44 AM

joshuaspence retitled this revision from to Use PHP type hinting in `ArcanistXHPASTLinter`..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 10 2014, 7:44 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B343: Diff 21465.May 10 2014, 7:45 AM

epriestley accepted this revision.May 10 2014, 8:56 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 10 2014, 8:56 AM

Closed by commit rARC20a05595226c (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistPhutilXHPASTLinter.php

6 lines

Diff 21465

View Options

src/lint/linter/ArcanistPhutilXHPASTLinter.php

Use PHP type hinting in `ArcanistXHPASTLinter`.ClosedPublicActions