Having a debug key in the .arclint file format doesn't seem right. Instead, it would be better to just use a PhutilConsole and the writeLog method so that "debug" messages are output when using arc --trace.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARC4298b4ea8b76: Remove `debug` key from `.arclint` file format.
Ran arc lint --trace in a repository using .arclint.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- arclint-debug
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 318 Build 318: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Three weak arguments for this are:
- This output is potentially much more verbose than most --trace output, and separating it might be useful.
- If arc is running via Harbormaster in the future, it may be difficult to add --trace.
- Having some key other than linters at top level might reduce confusion.
These are all pretty tenuous, though, and this is simpler and we can switch back if any of them prove compelling.
Comment Actions
Closed by commit rARC4298b4ea8b76 (authored by @joshuaspence, committed by @epriestley).