Paths

Table of Contentst

Reduce method visibility.
ClosedPublic
Actions

Authored by joshuaspence on May 6 2014, 3:28 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Feb 13, 3:05 PM

	Unknown Object (File)
	Tue, Jan 28, 6:33 AM

	Unknown Object (File)
	Sun, Jan 26, 11:41 PM

	Unknown Object (File)
	Sat, Jan 18, 2:05 AM

	Unknown Object (File)
	Jan 17 2025, 10:34 PM

	Unknown Object (File)
	Jan 7 2025, 3:45 AM

	Unknown Object (File)
	Dec 27 2024, 3:33 PM

	Unknown Object (File)
	Dec 17 2024, 6:21 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC48d52c30b07a: Reduce method visibility.

Summary

These methods are declared public, but there are meant to be protected (as they are declared in ArcanistExternalLinter).

Test Plan

N/A

Diff Detail

Repository

rARC Arcanist

Branch

jshint

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 264
Build 264: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 21348.May 6 2014, 3:28 AM

joshuaspence retitled this revision from to Reduce method visibility..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 6 2014, 3:28 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B264: Diff 21348.May 6 2014, 3:29 AM

epriestley accepted this revision.May 6 2014, 3:31 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 6 2014, 3:31 AM

Closed by commit rARC48d52c30b07a (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistJSHintLinter.php

4 lines

Diff 21348

View Options

src/lint/linter/ArcanistJSHintLinter.php

Reduce method visibility.ClosedPublicActions