Provide bindings for JSONLint, which is a useful tool for linting and validating JSON. Theoretically, this could be done with pure PHP, however it would not be trivial (json_decode, for example, does not provide any context as to JSON validation errors).
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARCab5c1562c0f6: Add a JSON linter.
Wrote and executed unit tests.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- jsonlint
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 262 Build 262: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Minor inlines, looks great in general.
| src/lint/linter/ArcanistJSONLintLinter.php | ||
|---|---|---|
| 16–28 | We should drop this stuff for new linters and just return 'jsonlint';. In the long run I want to get all of this stuff out of .arcconfig. The two ways to set it will be:
| |
| 32–34 | Probably a little cleaner to just list($err, $stdout) = execx_manual(...) -- that will also work on Windows. | |
| 63–64 | Same deal here, toss the config. | |
Comment Actions
Closed by commit rARCab5c1562c0f6 (authored by @joshuaspence, committed by @epriestley).