Page MenuHomePhabricator

Search - making clicking the search button not submit placeholder text
ClosedPublic

Authored by btrahan on May 2 2014, 11:52 PM.
Tags
None
Referenced Files
F14055308: D8960.diff
Sat, Nov 16, 10:17 AM
F14043056: D8960.diff
Tue, Nov 12, 7:27 AM
F14025898: D8960.diff
Thu, Nov 7, 9:03 PM
F13976203: D8960.diff
Oct 18 2024, 1:15 PM
F13961919: D8960.diff
Oct 15 2024, 7:01 AM
Unknown Object (File)
Sep 29 2024, 4:13 PM
Unknown Object (File)
Sep 29 2024, 4:13 PM
Unknown Object (File)
Sep 19 2024, 6:22 PM
Subscribers

Details

Summary

Need to wire up the button to have a click handler that clears out the placeholder text. Fixes T4847.

Test Plan

Clicked the search button and got results for nothing as opposed to "Search." Typed a search and clicked button and got expected results.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Search - making clicking the search button not submit placeholder text.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 3 2014, 12:46 AM
btrahan updated this revision to Diff 21259.

Closed by commit rPbfa880328780 (authored by @btrahan).