Differential D8961

Transactions - make ctrl + enter submit ajax-style
ClosedPublic
Actions

Authored by btrahan on May 3 2014, 12:42 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T4669: Submitting comment edits with ctrl+enter doesn't ajax

Commits

Restricted Diffusion Commit
rPc995e93bc1c3: Transactions - make ctrl + enter submit ajax-style

Summary

We were correctly invoking a didSyntheticSubmit event on the form, but nothing was listening to it. Re-jigger the workflow submit code a tad so an onsyntheticsubmit event handler can be written to fill this gap. Fixes T4669.

Test Plan

edited comments, submitting both via clicking the button and apple + enter LIKE A BOSS

Diff Detail

Repository

rP Phabricator

Branch

T4669

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 212
Build 212: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 21258.May 3 2014, 12:42 AM

btrahan added a task: T4669: Submitting comment edits with ctrl+enter doesn't ajax.

btrahan retitled this revision from to Transactions - make ctrl + enter submit ajax-style.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptMay 3 2014, 12:42 AM

Harbormaster completed remote builds in B212: Diff 21258.May 3 2014, 12:43 AM

I poked at this for a bit but couldn't come up with anything cleaner, seems reasonable to me.

This revision is now accepted and ready to land.May 3 2014, 12:58 AM

yah, I didn't feel good about it, but someone has to win the ugly contest.

Closed by commit rPc995e93bc1c3 (authored by @btrahan).

btrahan updated this object.May 3 2014, 1:06 AM

btrahan edited edge metadata.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

28 lines

webroot/

rsrc/

externals/

javelin/

lib/

Workflow.js

54 lines

Diff 21258

View Options

resources/celerity/map.php