Page MenuHomePhabricator

Search - making clicking the search button not submit placeholder text
ClosedPublic

Authored by btrahan on May 2 2014, 11:52 PM.
Tags
None
Referenced Files
F18111369: D8960.diff
Tue, Aug 12, 10:58 AM
F18088483: D8960.id21259.diff
Wed, Aug 6, 8:11 AM
F17997413: D8960.id21257.diff
Aug 2 2025, 5:12 AM
F17986440: D8960.id.diff
Aug 1 2025, 9:32 PM
F17947562: D8960.diff
Jul 31 2025, 5:21 PM
F17919274: D8960.id21257.diff
Jul 30 2025, 2:19 AM
F17852600: D8960.id21259.diff
Jul 27 2025, 12:51 PM
F17847455: D8960.diff
Jul 27 2025, 6:09 AM
Subscribers

Details

Summary

Need to wire up the button to have a click handler that clears out the placeholder text. Fixes T4847.

Test Plan

Clicked the search button and got results for nothing as opposed to "Search." Typed a search and clicked button and got expected results.

Diff Detail

Repository
rP Phabricator
Branch
T4847
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 211
Build 211: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Search - making clicking the search button not submit placeholder text.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 3 2014, 12:46 AM
btrahan updated this revision to Diff 21259.

Closed by commit rPbfa880328780 (authored by @btrahan).