Page MenuHomePhabricator

Transactions - fix edit submit URI
ClosedPublic

Authored by btrahan on May 2 2014, 4:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 5:25 AM
Unknown Object (File)
Mon, Jan 27, 7:07 AM
Unknown Object (File)
Wed, Jan 22, 7:51 PM
Unknown Object (File)
Sat, Jan 18, 6:29 AM
Unknown Object (File)
Fri, Jan 17, 8:21 AM
Unknown Object (File)
Fri, Jan 17, 7:15 AM
Unknown Object (File)
Fri, Jan 17, 2:17 AM
Unknown Object (File)
Dec 22 2024, 10:27 PM
Subscribers

Details

Summary

tracing this a bit, in core/behavior-form.js we end up doing form.submit() on this form. Before this patch, the form had no submitURI set so it ended up doing a page load. Now, we set the submitURI and (at least) the form is actually submitted and data is saved. Ref T4669.

Not sure how come the syntheticSubmit even isn't getting picked up though?

Test Plan

hit apple + enter to submit comment edit. page reloaded and my edit persisted!

Diff Detail

Repository
rP Phabricator
Branch
T4669
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 200
Build 200: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Transactions - fix edit submit URI.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/transactions/application/PhabricatorApplicationTransactions.php
13–15 ↗(On Diff #21241)

(I think this might have a weird side effect like making it show up in the main menu search typeahead?)

This revision is now accepted and ready to land.May 2 2014, 4:34 PM
src/applications/transactions/controller/PhabricatorApplicationTransactionCommentEditController.php
61–64

Oh, using $this->newDialog() might also fix this, since that should set a default submit URI based on the request URI.

btrahan edited edge metadata.

remove getBaseURI - it makes Transactions show up as an application search result

btrahan updated this revision to Diff 21243.

Closed by commit rP4e4a520b783e (authored by @btrahan).