Page MenuHomePhabricator
Differential D8944

Allow structured destruction of Maniphest tasks
ClosedPublic
Actions

Authored by epriestley on May 2 2014, 2:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 3:34 AM
Unknown Object (File)
Mon, Apr 29, 2:46 PM
Unknown Object (File)
Mon, Apr 29, 8:29 AM
Unknown Object (File)
Thu, Apr 25, 9:43 PM
Unknown Object (File)
Thu, Apr 25, 9:43 PM
Unknown Object (File)
Wed, Apr 24, 10:15 PM
Unknown Object (File)
Sat, Apr 20, 6:50 PM
Unknown Object (File)
Tue, Apr 16, 12:31 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
T4749: Implement bin/destroy for monogrammed objects
T4909: Rate limit or restrict access to comment removal
Commits
Restricted Diffusion Commit
rP6bced2170e75: Allow structured destruction of Maniphest tasks
Summary

Ref T4749. Ref T3265. Ref T4909.

  • Support ManiphestTasks in bin/remove.
  • Transactions need manual help for now.
Test Plan
  • Destroyed tasks.
  • Examined log to verify task, transaction, and comment destruction.

Diff Detail

Repository
rP Phabricator
Branch
rm4
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/maniphest/storage/ManiphestTask.php:295XHP16TODO Comment
Unit
No Test Coverage
Build Status
Buildable 185
Build 185: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21220.May 2 2014, 2:27 AM
epriestley retitled this revision from to Allow structured destruction of Maniphest tasks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T4909: Rate limit or restrict access to comment removal, T4749: Implement bin/destroy for monogrammed objects, Restricted Maniphest Task.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 2 2014, 2:27 AM
Harbormaster completed remote builds in B185: Diff 21220.May 2 2014, 2:29 AM
btrahan accepted this revision.May 2 2014, 3:32 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 2 2014, 3:32 PM
epriestley closed this revision.May 5 2014, 5:55 PM
epriestley updated this revision to Diff 21314.

Closed by commit rP6bced2170e75 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
storage/
25 lines

Diff 21220

View Options

src/applications/maniphest/storage/ManiphestTask.php

Loading...
Phabricator · Built by Phacility