Page MenuHomePhabricator
Differential D8920

Ask users to choose a pronoun instead of sex in the Account settings panel
ClosedPublic
Actions

Authored by lpriestley on Apr 30 2014, 9:13 PM.
Tags
None
Referenced Files
F15510835: D8920.id21160.diff
Wed, Apr 16, 9:17 PM
F15472235: D8920.diff
Sat, Apr 5, 11:50 AM
F15417656: D8920.id21169.diff
Mar 20 2025, 5:49 PM
F15417602: D8920.id21168.diff
Mar 20 2025, 5:39 PM
F15417601: D8920.id21160.diff
Mar 20 2025, 5:39 PM
F15417452: D8920.diff
Mar 20 2025, 5:03 PM
F15387533: D8920.id.diff
Mar 15 2025, 2:33 AM
F15386117: D8920.id21168.diff
Mar 15 2025, 12:04 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Love" token, awarded by qgil.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4845: Use "choose a pronoun" prompt for (grammatical) gender selection instead of "Sex"
Commits
Restricted Diffusion Commit
rPcf3f8cd809b4: Ask users to choose a pronoun instead of sex in the Account settings panel
Summary

Fixes T4845, Use "choose a pronoun" prompt for (grammatical) gender selection instead of "Sex"

Test Plan

Open Account settings panel, expand Pronoun dropdown, verify that options are "<username> updated their/her/his profile". Switch to different language, verify that pronouns propogate

Diff Detail

Repository
rP Phabricator
Branch
sextopronoun
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 155
Build 155: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 21160.Apr 30 2014, 9:13 PM
lpriestley retitled this revision from to Ask users to choose a pronoun instead of sex in the Account settings panel.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T4845: Use "choose a pronoun" prompt for (grammatical) gender selection instead of "Sex".
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 30 2014, 9:13 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B154: Diff 21160.Apr 30 2014, 9:14 PM
qgil awarded a token.Apr 30 2014, 9:17 PM
epriestley requested changes to this revision.Apr 30 2014, 9:26 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/settings/panel/PhabricatorSettingsPanelAccount.php
64–65

These two are flipped (male => her).

This revision now requires changes to proceed.Apr 30 2014, 9:26 PM
lpriestley updated this revision to Diff 21168.Apr 30 2014, 9:40 PM
lpriestley edited edge metadata.

Addressing feedback, fixing his/her mapping

epriestley accepted this revision.Apr 30 2014, 9:41 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 30 2014, 9:41 PM
Harbormaster completed remote builds in B155: Diff 21168.Apr 30 2014, 9:42 PM
epriestley closed this revision.Apr 30 2014, 9:42 PM
epriestley updated this revision to Diff 21169.

Closed by commit rPcf3f8cd809b4 (authored by @lpriestley, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
settings/
panel/
14 lines

Diff 21168

View Options

src/applications/settings/panel/PhabricatorSettingsPanelAccount.php

Loading...
Phabricator · Built by Phacility