Differential D8920

Ask users to choose a pronoun instead of sex in the Account settings panel
ClosedPublic
Actions

Authored by lpriestley on Apr 30 2014, 9:13 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4845: Use "choose a pronoun" prompt for (grammatical) gender selection instead of "Sex"

Commits

Restricted Diffusion Commit
rPcf3f8cd809b4: Ask users to choose a pronoun instead of sex in the Account settings panel

Summary

Fixes T4845, Use "choose a pronoun" prompt for (grammatical) gender selection instead of "Sex"

Test Plan

Open Account settings panel, expand Pronoun dropdown, verify that options are "<username> updated their/her/his profile". Switch to different language, verify that pronouns propogate

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

lpriestley updated this revision to Diff 21160.Apr 30 2014, 9:13 PM

lpriestley retitled this revision from to Ask users to choose a pronoun instead of sex in the Account settings panel.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T4845: Use "choose a pronoun" prompt for (grammatical) gender selection instead of "Sex".

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 30 2014, 9:13 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B154: Diff 21160.Apr 30 2014, 9:14 PM

qgil awarded a token.Apr 30 2014, 9:17 PM

epriestley requested changes to this revision.Apr 30 2014, 9:26 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/settings/panel/PhabricatorSettingsPanelAccount.php
64–65	These two are flipped (male => her).

This revision now requires changes to proceed.Apr 30 2014, 9:26 PM

Addressing feedback, fixing his/her mapping

epriestley accepted this revision.Apr 30 2014, 9:41 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 30 2014, 9:41 PM

Harbormaster completed remote builds in B155: Diff 21168.Apr 30 2014, 9:42 PM

Closed by commit rPcf3f8cd809b4 (authored by @lpriestley, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

panel/

PhabricatorSettingsPanelAccount.php

14 lines

Diff 21169

View Options

src/applications/settings/panel/PhabricatorSettingsPanelAccount.php

Ask users to choose a pronoun instead of sex in the Account settings panelClosedPublicActions