Page MenuHomePhabricator
Differential D8919

Let dashboard panel types use customfield to manage editing
ClosedPublic
Actions

Authored by epriestley on Apr 30 2014, 8:27 PM.
Tags
None
Referenced Files
F13172339: D8919.diff
Tue, May 7, 3:09 PM
F13165469: D8919.diff
Tue, May 7, 5:24 AM
Unknown Object (File)
Sat, May 4, 11:36 PM
Unknown Object (File)
Fri, May 3, 3:11 AM
Unknown Object (File)
Mon, Apr 29, 2:48 PM
Unknown Object (File)
Wed, Apr 24, 10:09 PM
Unknown Object (File)
Sat, Apr 20, 6:49 PM
Unknown Object (File)
Thu, Apr 11, 7:02 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T3583: Fix the Swamp of Suck that is the home page content panel
Commits
Restricted Diffusion Commit
rPd41416faf0ae: Let dashboard panel types use customfield to manage editing
Summary

Ref T3583. Use the same approach Harbormaster does to give panels cheap forms.

Test Plan

Screen_Shot_2014-04-30_at_1.25.18_PM.png (1×1 px, 166 KB)

Screen_Shot_2014-04-30_at_1.25.06_PM.png (1×1 px, 105 KB)

Screen_Shot_2014-04-30_at_1.25.09_PM.png (1×1 px, 144 KB)

Diff Detail

Repository
rP Phabricator
Branch
dash5
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 153
Build 153: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21159.Apr 30 2014, 8:27 PM
epriestley retitled this revision from to Let dashboard panel types use customfield to manage editing.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added a task: T3583: Fix the Swamp of Suck that is the home page content panel.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 30 2014, 8:27 PM
Harbormaster completed remote builds in B153: Diff 21159.Apr 30 2014, 8:28 PM
btrahan accepted this revision.Apr 30 2014, 9:27 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 30 2014, 9:27 PM
epriestley closed this revision.Apr 30 2014, 9:29 PM
epriestley updated this revision to Diff 21165.

Closed by commit rPd41416faf0ae (authored by @epriestley).

Revision Contents
Changeset List

Diff 21159

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php

Loading...
View Options

src/applications/dashboard/customfield/PhabricatorDashboardPanelCoreCustomField.php

Loading...
View Options

src/applications/dashboard/customfield/PhabricatorDashboardPanelCustomField.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeText.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

Loading...
View Options

src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php

Loading...
Phabricator · Built by Phacility