Differential D8918

Phame - add some application polish.
ClosedPublic
Actions

Authored by btrahan on Apr 30 2014, 8:14 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 10, 8:20 AM

	Unknown Object (File)
	Tue, Nov 5, 1:25 PM

	Unknown Object (File)
	Tue, Nov 5, 1:25 PM

	Unknown Object (File)
	Tue, Nov 5, 1:24 PM

	Unknown Object (File)
	Sun, Oct 27, 2:11 PM

	Unknown Object (File)
	Oct 20 2024, 6:34 PM

	Unknown Object (File)
	Oct 20 2024, 8:07 AM

	Unknown Object (File)
	Oct 18 2024, 3:00 PM

Subscribers

Details

Reviewers

epriestley
chad

Maniphest Tasks

T4880: Phame needs polish

Commits

Restricted Diffusion Commit
rP5f02ed5bbb7d: Phame - add some application polish.

Summary

Fixes T4880. More specifically

adds an "edit" pencil to post lists iff you can edit the post
- style change so this has no text-decoration
adds a "no data" box if you have no posts in a given view
- style change to crush some margins so it formats like posts do
adds some validation that your configuration is correct if you are specifying a custom domain
updates docs about custom domains

Test Plan

clicked around and it was better! (see screenshots) read doc changes carefully

Diff Detail

Repository

Branch

T4880

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 151
Build 151: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 21156.Apr 30 2014, 8:14 PM

btrahan added a task: T4880: Phame needs polish.

btrahan retitled this revision from to Phame - add some application polish..

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added a reviewer: chad. · View Herald TranscriptApr 30 2014, 8:14 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Screen_Shot_2014-04-30_at_1.11.24_PM.png (1×1 px, 392 KB)

Screen_Shot_2014-04-30_at_1.11.39_PM.png (1×1 px, 495 KB)

Screen_Shot_2014-04-30_at_1.11.53_PM.png (1×1 px, 396 KB)

Screen_Shot_2014-04-30_at_1.11.45_PM.png (1×1 px, 457 KB)

Screen_Shot_2014-04-30_at_1.11.59_PM.png (1×1 px, 444 KB)

Harbormaster completed remote builds in B151: Diff 21156.Apr 30 2014, 8:15 PM

epriestley accepted this revision.Apr 30 2014, 8:17 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/phame/controller/blog/PhameBlogEditController.php
83	(By convention, omit period for these.)

This revision is now accepted and ready to land.Apr 30 2014, 8:17 PM

follow convention and axe that trailing period

Closed by commit rP5f02ed5bbb7d (authored by @btrahan).

Harbormaster completed remote builds in B152: Diff 21157.Apr 30 2014, 8:19 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

4 lines

src/

applications/

phame/

controller/

PhameController.php

25 lines

blog/

PhameBlogEditController.php

28 lines

storage/

60 lines

7 lines

docs/

user/

userguide/

16 lines

webroot/

rsrc/

css/

application/

phame/

8 lines

Diff 21156

resources/celerity/map.php

Loading...

src/applications/phame/controller/PhameController.php

Loading...

src/applications/phame/controller/blog/PhameBlogEditController.php

Loading...

src/applications/phame/storage/PhameBlog.php

Loading...

src/applications/phame/storage/PhamePost.php

Loading...

src/docs/user/userguide/phame.diviner

Loading...

webroot/rsrc/css/application/phame/phame.css

Loading...