Page MenuHomePhabricator

Phame - add some application polish.
ClosedPublic

Authored by btrahan on Apr 30 2014, 8:14 PM.
Tags
None
Referenced Files
F14018467: D8918.id21157.diff
Tue, Nov 5, 1:25 PM
F14018466: D8918.id21156.diff
Tue, Nov 5, 1:25 PM
F14018465: D8918.id21158.diff
Tue, Nov 5, 1:24 PM
F14005502: D8918.id21158.diff
Sun, Oct 27, 2:11 PM
F13985175: D8918.diff
Sun, Oct 20, 6:34 PM
F13983691: D8918.id.diff
Sun, Oct 20, 8:07 AM
F13976600: D8918.id21156.diff
Fri, Oct 18, 3:00 PM
Unknown Object (File)
Oct 7 2024, 7:54 AM
Subscribers

Details

Reviewers
epriestley
chad
Maniphest Tasks
T4880: Phame needs polish
Commits
Restricted Diffusion Commit
rP5f02ed5bbb7d: Phame - add some application polish.
Summary

Fixes T4880. More specifically

  • adds an "edit" pencil to post lists iff you can edit the post
    • style change so this has no text-decoration
  • adds a "no data" box if you have no posts in a given view
    • style change to crush some margins so it formats like posts do
  • adds some validation that your configuration is correct if you are specifying a custom domain
  • updates docs about custom domains
Test Plan

clicked around and it was better! (see screenshots) read doc changes carefully

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Phame - add some application polish..
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phame/controller/blog/PhameBlogEditController.php
83

(By convention, omit period for these.)

This revision is now accepted and ready to land.Apr 30 2014, 8:17 PM
btrahan edited edge metadata.

follow convention and axe that trailing period

btrahan updated this revision to Diff 21158.

Closed by commit rP5f02ed5bbb7d (authored by @btrahan).