Page MenuHomePhabricator

Rate limit multi-factor actions
ClosedPublic

Authored by epriestley on Apr 30 2014, 4:21 PM.
Tags
None
Referenced Files
F13083195: D8911.diff
Wed, Apr 24, 10:28 PM
Unknown Object (File)
Fri, Apr 19, 7:35 PM
Unknown Object (File)
Mon, Apr 15, 1:48 PM
Unknown Object (File)
Feb 7 2024, 8:09 PM
Unknown Object (File)
Jan 19 2024, 8:37 AM
Unknown Object (File)
Jan 16 2024, 8:18 PM
Unknown Object (File)
Dec 30 2023, 4:54 PM
Unknown Object (File)
Dec 29 2023, 7:11 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
T4398: Implement two-factor authentication
Commits
Restricted Diffusion Commit
rP23e654ec2bc8: Rate limit multi-factor actions
Summary

Ref T4398. Prevent users from brute forcing multi-factor auth by rate limiting attempts. This slightly refines the rate limiting to allow callers to check for a rate limit without adding points, and gives users credit for successfully completing an auth workflow.

Test Plan

Tried to enter hisec with bad credentials 11 times in a row, got rate limited.

Diff Detail

Repository
rP Phabricator
Branch
hisec8
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 143
Build 143: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Rate limit multi-factor actions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 30 2014, 6:32 PM
epriestley updated this revision to Diff 21167.

Closed by commit rP23e654ec2bc8 (authored by @epriestley).