Page MenuHomePhabricator
Differential D8906

Fix Diffusion crash
ClosedPublic
Actions

Authored by hach-que on Apr 30 2014, 2:05 AM.
Tags
None
Referenced Files
F14118091: D8906.diff
Thu, Nov 28, 9:56 PM
Unknown Object (File)
Fri, Nov 8, 4:25 PM
Unknown Object (File)
Sat, Nov 2, 6:12 PM
Unknown Object (File)
Fri, Nov 1, 5:31 AM
Unknown Object (File)
Oct 24 2024, 10:58 AM
Unknown Object (File)
Oct 23 2024, 7:38 PM
Unknown Object (File)
Oct 19 2024, 10:33 AM
Unknown Object (File)
Oct 17 2024, 1:09 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP466af3314790: Fix Diffusion crash
Summary

This fixes a crash that happens when visiting Diffusion pages due to an undefined variable. $title is only defined if it has a status to show, but then it uses it anyway and fails.

Test Plan

Pages stopped crashing and people stopped complaining.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que updated this revision to Diff 21140.Apr 30 2014, 2:05 AM
hach-que retitled this revision from to Fix Diffusion crash.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 30 2014, 2:05 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B138: Diff 21140.Apr 30 2014, 2:06 AM
epriestley accepted this revision.Apr 30 2014, 2:06 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 30 2014, 2:06 AM
epriestley closed this revision.Apr 30 2014, 2:07 AM
epriestley updated this revision to Diff 21141.
epriestley added a subscriber: Unknown Object (User).

Closed by commit rP466af3314790 (authored by @jamesr, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
1 line

Diff 21141

View Options

src/applications/diffusion/controller/DiffusionController.php

Loading...
Phabricator · Built by Phacility