Paths

Table of Contentst

Differential D8906

Fix Diffusion crash
ClosedPublic
Actions

Authored by hach-que on Apr 30 2014, 2:05 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP466af3314790: Fix Diffusion crash

Summary

This fixes a crash that happens when visiting Diffusion pages due to an undefined variable. $title is only defined if it has a status to show, but then it uses it anyway and fails.

Test Plan

Pages stopped crashing and people stopped complaining.

Diff Detail

Repository

rP Phabricator

Branch

fix-diffusion-crash

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 138
Build 138: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 21140.Apr 30 2014, 2:05 AM

hach-que retitled this revision from to Fix Diffusion crash.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 30 2014, 2:05 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B138: Diff 21140.Apr 30 2014, 2:06 AM

epriestley accepted this revision.Apr 30 2014, 2:06 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 30 2014, 2:06 AM

Closed by commit rP466af3314790 (authored by @jamesr, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionController.php

1 line

Diff 21140

View Options

src/applications/diffusion/controller/DiffusionController.php

Fix Diffusion crashClosedPublicActions