Page MenuHomePhabricator

Fix Diffusion crash
ClosedPublic

Authored by hach-que on Apr 30 2014, 2:05 AM.
Tags
None
Referenced Files
F14028827: D8906.id21140.diff
Fri, Nov 8, 4:25 PM
F14013881: D8906.diff
Sat, Nov 2, 6:12 PM
F14011859: D8906.diff
Fri, Nov 1, 5:31 AM
F13998746: D8906.diff
Thu, Oct 24, 10:58 AM
F13996271: D8906.id21141.diff
Wed, Oct 23, 7:38 PM
F13980423: D8906.diff
Sat, Oct 19, 10:33 AM
F13969205: D8906.id21140.diff
Thu, Oct 17, 1:09 AM
F13968347: D8906.id.diff
Wed, Oct 16, 8:20 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP466af3314790: Fix Diffusion crash
Summary

This fixes a crash that happens when visiting Diffusion pages due to an undefined variable. $title is only defined if it has a status to show, but then it uses it anyway and fails.

Test Plan

Pages stopped crashing and people stopped complaining.

Diff Detail

Repository
rP Phabricator
Branch
fix-diffusion-crash
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 138
Build 138: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que retitled this revision from to Fix Diffusion crash.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 30 2014, 2:06 AM
epriestley updated this revision to Diff 21141.
epriestley added a subscriber: Unknown Object (User).

Closed by commit rP466af3314790 (authored by @jamesr, committed by @epriestley).