Page MenuHomePhabricator

Fix Diffusion crash
ClosedPublic

Authored by hach-que on Apr 30 2014, 2:05 AM.
Tags
None
Referenced Files
F15429652: D8906.id21140.diff
Mon, Mar 24, 3:30 AM
F15409392: D8906.id21140.diff
Wed, Mar 19, 4:29 AM
F15403755: D8906.diff
Tue, Mar 18, 4:41 AM
F15382372: D8906.id21140.diff
Fri, Mar 14, 12:05 PM
F15377183: D8906.id21140.diff
Thu, Mar 13, 8:20 AM
F15341155: D8906.diff
Sun, Mar 9, 6:52 PM
F15333165: D8906.id.diff
Sat, Mar 8, 12:28 AM
F15332961: D8906.diff
Fri, Mar 7, 10:42 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP466af3314790: Fix Diffusion crash
Summary

This fixes a crash that happens when visiting Diffusion pages due to an undefined variable. $title is only defined if it has a status to show, but then it uses it anyway and fails.

Test Plan

Pages stopped crashing and people stopped complaining.

Diff Detail

Repository
rP Phabricator
Branch
fix-diffusion-crash
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 138
Build 138: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que retitled this revision from to Fix Diffusion crash.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 30 2014, 2:06 AM
epriestley updated this revision to Diff 21141.
epriestley added a subscriber: Unknown Object (User).

Closed by commit rP466af3314790 (authored by @jamesr, committed by @epriestley).