Page MenuHomePhabricator
Differential D8891

Add a Stacked view for PropertyList
ClosedPublic
Actions

Authored by chad on Apr 29 2014, 4:45 AM.
Tags
None
Referenced Files
F15410354: D8891.id21093.diff
Wed, Mar 19, 7:07 AM
F15407229: D8891.id.diff
Tue, Mar 18, 4:26 PM
F15403588: D8891.id21093.diff
Tue, Mar 18, 4:00 AM
F15402811: D8891.id.diff
Tue, Mar 18, 12:27 AM
F15401568: D8891.id21099.diff
Mon, Mar 17, 6:18 PM
F15401239: D8891.id21094.diff
Mon, Mar 17, 4:30 PM
F15397166: D8891.diff
Sun, Mar 16, 6:34 PM
F15380840: D8891.diff
Fri, Mar 14, 4:42 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP3bc2db199a49: Add a Stacked view for PropertyList
Summary

Turns a Property List into a stacked view like on tablet/mobile. Useful for where text is longer.

Test Plan

Test a Herald Transcript page

Screen_Shot_2014-04-28_at_9.43.17_PM.png (536×1 px, 88 KB)

Screen_Shot_2014-04-28_at_9.41.55_PM.png (966×1 px, 107 KB)

Diff Detail

Repository
rP Phabricator
Branch
prop-list
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 113
Build 113: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 21093.Apr 29 2014, 4:45 AM
chad retitled this revision from to Add a Stacked view for PropertyList.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptApr 29 2014, 4:45 AM
chad edited the test plan for this revision. (Show Details)Apr 29 2014, 4:45 AM
Harbormaster completed remote builds in B112: Diff 21093.Apr 29 2014, 4:46 AM
chad updated this revision to Diff 21094.Apr 29 2014, 4:48 AM
  • More consise CSS
Harbormaster completed remote builds in B113: Diff 21094.Apr 29 2014, 4:49 AM
epriestley accepted this revision.Apr 29 2014, 11:54 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 29 2014, 11:54 AM
chad closed this revision.Apr 29 2014, 2:04 PM
chad updated this revision to Diff 21099.

Closed by commit rP3bc2db199a49 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
herald/
controller/
1 line
view/
phui/
13 lines
webroot/
rsrc/
css/
phui/
14 lines

Diff 21094

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/herald/controller/HeraldTranscriptController.php

Loading...
View Options

src/view/phui/PHUIPropertyListView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-property-list-view.css

Loading...
Phabricator · Built by Phacility