Page MenuHomePhabricator
Differential D8885

Update inline-comment styles in Differential
ClosedPublic
Actions

Authored by chad on Apr 28 2014, 4:45 PM.
Tags
None
Referenced Files
F14032831: D8885.id21091.diff
Sat, Nov 9, 3:55 PM
F14028829: D8885.id21079.diff
Fri, Nov 8, 4:29 PM
F14028479: D8885.id21091.diff
Fri, Nov 8, 1:37 PM
F14013411: D8885.id21091.diff
Sat, Nov 2, 6:48 AM
F13972600: D8885.diff
Thu, Oct 17, 8:00 PM
F13965741: D8885.id21091.diff
Wed, Oct 16, 4:03 AM
F13964866: D8885.id21079.diff
Tue, Oct 15, 10:21 PM
F13956638: D8885.id21078.diff
Mon, Oct 14, 6:28 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rPa46ead798007: Update inline-comment styles in Differential
Summary

Moderize Inline Comment Display

  • Use standard colors
  • Better display with/without comment
  • OMG Icons
Test Plan

Screen_Shot_2014-04-28_at_9.42.52_AM.png (632×541 px, 46 KB)

Test with and without main comment, test with many for few comments on 1-3 files.

Diff Detail

Repository
rP Phabricator
Branch
inline-comments
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 100
Build 100: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 21078.Apr 28 2014, 4:45 PM
chad retitled this revision from to Update inline-comment styles in Differential.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptApr 28 2014, 4:45 PM
chad edited the test plan for this revision. (Show Details)Apr 28 2014, 4:46 PM
Harbormaster completed remote builds in B100: Diff 21078.Apr 28 2014, 4:46 PM
chad updated this revision to Diff 21079.Apr 28 2014, 4:48 PM
  • fix anchor width back to 100
Harbormaster completed remote builds in B101: Diff 21079.Apr 28 2014, 4:49 PM
btrahan accepted this revision.Apr 28 2014, 10:02 PM
btrahan edited edge metadata.

Haha, love the test data.

This revision is now accepted and ready to land.Apr 28 2014, 10:02 PM
chad closed this revision.Apr 29 2014, 2:43 AM
chad updated this revision to Diff 21091.

Closed by commit rPa46ead798007 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
infrastructure/
diff/
view/
14 lines
webroot/
rsrc/
css/
application/
diff/
33 lines

Diff 21078

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/diff/view/PhabricatorInlineSummaryView.php

Loading...
View Options

webroot/rsrc/css/application/diff/inline-comment-summary.css

Loading...
Phabricator · Built by Phacility