Page MenuHomePhabricator

Moderize Herald UI
ClosedPublic

Authored by chad on Apr 25 2014, 5:31 PM.
Tags
None
Referenced Files
F13187649: D8860.diff
Sat, May 11, 4:40 AM
F13184031: D8860.id21018.diff
Fri, May 10, 2:24 PM
F13184030: D8860.id21055.diff
Fri, May 10, 2:24 PM
Unknown Object (File)
Tue, May 7, 7:02 AM
Unknown Object (File)
Fri, May 3, 6:04 AM
Unknown Object (File)
Thu, May 2, 12:25 AM
Unknown Object (File)
Mon, Apr 29, 4:42 PM
Unknown Object (File)
Sun, Apr 28, 8:23 PM
Subscribers

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPc453e98c4093: Moderize Herald UI
Summary

Removes many tables and uses PropertyLists and ObjectItemList when possible. Adds cleaner CSS, makes mobile editing more possible.

Test Plan

Test new UI on desktop and mobile. Verify all functionality still exists.

Diff Detail

Repository
rP Phabricator
Branch
herald-yo-momma
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 67
Build 67: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad retitled this revision from to Moderize Herald UI.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: Restricted Maniphest Task.Apr 25 2014, 5:33 PM
epriestley edited edge metadata.

Nice!

One minor thing: instead of "View Transcript" as a link, I think the transcript's main link should probably go to the transcript, and then we should either put like D1234 and link it in the attributes or just omit that entirely. I mess this up fairly often on the current UI (i.e., you 99% of the time want to go to the transcript from this UI, and it's confusing that the biggest link doesn't take you there). We can easily tweak this later, though.

This revision is now accepted and ready to land.Apr 26 2014, 8:43 PM

Yeah I didn't like that either, should have just swapped them.

chad updated this revision to Diff 21055.

Closed by commit rPc453e98c4093 (authored by @chad).