Page MenuHomePhabricator
Differential D8840

Adjust reviewer transaction icon in Differential
ClosedPublic
Actions

Authored by epriestley on Apr 22 2014, 9:31 PM.
Tags
None
Referenced Files
F15459514: D8840.id20975.diff
Mon, Mar 31, 1:43 PM
F15458545: D8840.id.diff
Mon, Mar 31, 4:34 AM
F15458478: D8840.id20976.diff
Mon, Mar 31, 3:59 AM
F15456799: D8840.diff
Sun, Mar 30, 12:18 PM
F15437961: D8840.id20976.diff
Tue, Mar 25, 10:21 PM
F15437959: D8840.id20975.diff
Tue, Mar 25, 10:21 PM
F15433769: D8840.diff
Tue, Mar 25, 12:35 AM
F15412981: D8840.diff
Wed, Mar 19, 4:10 PM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Maniphest Tasks
T4866: List of more-doughy-than-desirable transaction icons
Commits
Restricted Diffusion Commit
rPa88f09469d22: Adjust reviewer transaction icon in Differential
Summary

Ref T4866. I did a fancy version of this but it looks pretty bad/confusing so here's a simple version.

Fancy-but-whack version:

Screen_Shot_2014-04-22_at_2.29.42_PM.png (131×452 px, 19 KB)

Test Plan

This version is like that, but just always uses fa-user.

Diff Detail

Repository
rP Phabricator
Branch
blobs
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 43
Build 43: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 20975.Apr 22 2014, 9:31 PM
epriestley retitled this revision from to Adjust reviewer transaction icon in Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 22 2014, 9:31 PM
epriestley updated this object.Apr 22 2014, 9:31 PM
epriestley added a task: T4866: List of more-doughy-than-desirable transaction icons.
chad accepted this revision.Apr 22 2014, 9:32 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 22 2014, 9:32 PM
Harbormaster completed remote builds in B43: Diff 20975.Apr 22 2014, 9:32 PM
epriestley closed this revision.Apr 22 2014, 9:32 PM
epriestley updated this revision to Diff 20976.

Closed by commit rPa88f09469d22 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
storage/
5 lines

Diff 20975

View Options

src/applications/differential/storage/DifferentialTransaction.php

Loading...
Phabricator · Built by Phacility