Page MenuHomePhabricator
Differential D8832

Clean up numerous rough edges in Mail configuration
ClosedPublic
Actions

Authored by epriestley on Apr 21 2014, 9:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 10, 9:57 AM
Unknown Object (File)
Tue, Sep 10, 9:57 AM
Unknown Object (File)
Sat, Aug 31, 12:21 AM
Unknown Object (File)
Fri, Aug 30, 8:55 AM
Unknown Object (File)
Sun, Aug 25, 6:38 PM
Unknown Object (File)
Fri, Aug 23, 10:44 PM
Unknown Object (File)
Aug 18 2024, 9:27 PM
Unknown Object (File)
Aug 18 2024, 9:26 PM
View All Files
Subscribers
epriestley
Tokens
"Haypence" token, awarded by chad."Pterodactyl" token, awarded by epriestley.

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rPfcf5149b3648: Clean up numerous rough edges in Mail configuration
Summary
  • Support file attachments in Mailgun, after D8831.
  • Fix bin/mail send-test --attach ... flag.
  • Make bin/mail send-test route mail through the daemons.
  • Remove the workerTaskID on MetaMTAMail, which is only used (needlessly) by bin/mail resend and creates a huge mess elsewhere.
  • Currently, when mail fails, the daemon exits with a very generic and useless message. Instead, make sendNow() throw when it fails, so the real reason is surfaced. This is OK now because mail is always sent via the daemons.
  • Now that Mailgun supports attachments, document it.
  • Update a bunch of mail docs.
Test Plan
  • Sent mail.
  • Sent mail with attachments.
  • Read documentation.

Diff Detail

Repository
rP Phabricator
Branch
mail1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/metamta/storage/PhabricatorMetaMTAMail.php:626XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 34
Build 34: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 20955.Apr 21 2014, 9:42 PM
epriestley retitled this revision from to Clean up numerous rough edges in Mail configuration.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 21 2014, 9:42 PM
Harbormaster completed remote builds in B34: Diff 20955.Apr 21 2014, 9:43 PM
btrahan accepted this revision.Apr 21 2014, 10:43 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 21 2014, 10:43 PM
epriestley closed this revision.Apr 21 2014, 10:45 PM
epriestley updated this revision to Diff 20965.

Closed by commit rPfcf5149b3648 (authored by @epriestley).

epriestley added a comment.Apr 21 2014, 11:11 PM

SORRY CHAD I WILL PUSH SO YOU CAN GET YOUR TRANSACTIONS

epriestley awarded a token.Apr 21 2014, 11:12 PM
chad rescinded a token.Apr 21 2014, 11:20 PM
chad awarded a token.

Revision Contents
Changeset List

Diff 20955

View Options

src/applications/metamta/PhabricatorMetaMTAWorker.php

Loading...
View Options

src/applications/metamta/adapter/PhabricatorMailImplementationMailgunAdapter.php

Loading...
View Options

src/applications/metamta/management/PhabricatorMailManagementResendWorkflow.php

Loading...
View Options

src/applications/metamta/management/PhabricatorMailManagementSendTestWorkflow.php

Loading...
View Options

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

Loading...
View Options

src/applications/metamta/storage/__tests__/PhabricatorMetaMTAMailTestCase.php

Loading...
View Options

src/docs/user/configuration/configuring_inbound_email.diviner

Loading...
View Options

src/docs/user/configuration/configuring_outbound_email.diviner

Loading...
Phabricator · Built by Phacility