Page MenuHomePhabricator
Differential D8829

Paradigms, paradigms, paradigms
ClosedPublic
Actions

Authored by epriestley on Apr 20 2014, 11:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 21, 2:10 AM
Unknown Object (File)
Thu, Sep 5, 8:47 AM
Unknown Object (File)
Fri, Aug 30, 3:14 AM
Unknown Object (File)
Aug 26 2024, 12:35 AM
Unknown Object (File)
Aug 25 2024, 4:54 AM
Unknown Object (File)
Aug 18 2024, 11:17 PM
Unknown Object (File)
Aug 18 2024, 11:17 PM
Unknown Object (File)
Aug 18 2024, 11:16 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T4693: Leverage new timeline design to optimize growth metrics
Commits
Restricted Diffusion Commit
rP5cbdda413cf7: Paradigms, paradigms, paradigms
Summary

Fixes T4693.

Test Plan

Screen_Shot_2014-04-20_at_3.57.56_PM.png (191×338 px, 20 KB)

Diff Detail

Repository
rP Phabricator
Branch
tok1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29
Build 29: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 20948.Apr 20 2014, 11:03 PM
epriestley retitled this revision from to Paradigms, paradigms, paradigms.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added a task: T4693: Leverage new timeline design to optimize growth metrics.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 20 2014, 11:03 PM
epriestley updated this revision to Diff 20949.Apr 20 2014, 11:04 PM
  • Slightly fewer paradigms.
Harbormaster completed remote builds in B27: Diff 20948.Apr 20 2014, 11:04 PM
Harbormaster completed remote builds in B28: Diff 20949.
epriestley updated this revision to Diff 20950.Apr 20 2014, 11:45 PM
  • Don't implement the interface in ManiphestTask yet since I think it interacts with some other stuff in sketchy ways.
Harbormaster completed remote builds in B29: Diff 20950.Apr 20 2014, 11:46 PM
chad edited edge metadata.Apr 21 2014, 1:18 AM

dealwithit

btrahan accepted this revision.Apr 21 2014, 9:23 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/tokens/editor/PhabricatorTokenGivenEditor.php
146

This function came out really nicely - a testament to the transaction + editor infrastructure working well.

This revision is now accepted and ready to land.Apr 21 2014, 9:23 PM
epriestley closed this revision.Apr 21 2014, 10:34 PM
epriestley updated this revision to Diff 20960.

Closed by commit rP5cbdda413cf7 (authored by @epriestley).

Revision Contents
Changeset List

Diff 20950

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/tokens/conduit/ConduitAPI_token_give_Method.php

Loading...
View Options

src/applications/tokens/controller/PhabricatorTokenGiveController.php

Loading...
View Options

src/applications/tokens/editor/PhabricatorTokenGivenEditor.php

Loading...
View Options

src/applications/transactions/constants/PhabricatorTransactions.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
View Options

src/applications/transactions/interface/PhabricatorApplicationTransactionInterface.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-timeline-view.css

Loading...
Phabricator · Built by Phacility