Page MenuHomePhabricator
Differential D8819

Remove some ad-hoc handle loads from Releeph
ClosedPublic
Actions

Authored by epriestley on Apr 19 2014, 4:47 PM.
Tags
None
Referenced Files
F14059323: D8819.diff
Sun, Nov 17, 7:01 PM
F14034608: D8819.id20927.diff
Sun, Nov 10, 1:20 AM
F14034606: D8819.id20926.diff
Sun, Nov 10, 1:17 AM
F14033458: D8819.diff
Sat, Nov 9, 5:41 PM
F14030784: D8819.diff
Sat, Nov 9, 6:42 AM
F14030711: D8819.diff
Sat, Nov 9, 5:38 AM
F14005227: D8819.id.diff
Sun, Oct 27, 9:33 AM
F14004894: D8819.id20937.diff
Sun, Oct 27, 4:39 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPa4f975ef3e45: Remove some ad-hoc handle loads from Releeph
Summary

Ref T3551. Releeph does a bunch of old-school on-object data loading; start cleaning that up.

This doesn't change anything, just makes the code more modern/consistent.

Test Plan

Edited a request; called releephwork.nextrequest.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20926.Apr 19 2014, 4:47 PM
epriestley retitled this revision from to Remove some ad-hoc handle loads from Releeph.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: Restricted Maniphest Task.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 19 2014, 4:47 PM
Harbormaster completed remote builds in B15: Diff 20926.Apr 19 2014, 4:48 PM
epriestley updated this revision to Diff 20927.Apr 19 2014, 4:52 PM
  • Remove some more handle-related stuff.
Harbormaster completed remote builds in B16: Diff 20927.Apr 19 2014, 4:53 PM
btrahan accepted this revision.Apr 20 2014, 4:31 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/releeph/conduit/work/ConduitAPI_releephwork_nextrequest_Method.php
49–53

seems about right for a conduit method called "next request" :P

This revision is now accepted and ready to land.Apr 20 2014, 4:31 PM
epriestley closed this revision.Apr 20 2014, 6:54 PM
epriestley updated this revision to Diff 20937.

Closed by commit rPa4f975ef3e45 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
releeph/
conduit/
18 lines
work/
11 lines
controller/
request/
15 lines
field/
specification/
24 lines
storage/
40 lines
12 lines

Diff 20937

View Options

src/applications/releeph/conduit/ConduitAPI_releeph_request_Method.php

Loading...
View Options

src/applications/releeph/conduit/work/ConduitAPI_releephwork_nextrequest_Method.php

Loading...
View Options

src/applications/releeph/controller/request/ReleephRequestEditController.php

Loading...
View Options

src/applications/releeph/field/specification/ReleephBranchCommitFieldSpecification.php

Loading...
View Options

src/applications/releeph/storage/ReleephBranch.php

Loading...
View Options

src/applications/releeph/storage/ReleephRequest.php

Loading...
Phabricator · Built by Phacility