Paths

Table of Contentst

Differential D8800

Add `activeDiffPHID` to differential.query
ClosedPublic
Actions

Authored by epriestley on Apr 17 2014, 4:06 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 17, 6:31 AM

	Unknown Object (File)
	Fri, Dec 13, 4:09 AM

	Unknown Object (File)
	Thu, Dec 12, 1:05 AM

	Unknown Object (File)
	Thu, Dec 12, 1:05 AM

	Unknown Object (File)
	Thu, Dec 12, 12:48 AM

	Unknown Object (File)
	Thu, Dec 12, 12:35 AM

	Unknown Object (File)
	Sun, Dec 8, 6:35 PM

	Unknown Object (File)
	Fri, Dec 6, 5:30 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T1049: Implement Harbormaster
T4809: Make "arc land" complain if builds are still executing or have failed

Commits

Restricted Diffusion Commit
rP62973e0f5396: Add `activeDiffPHID` to differential.query

Summary

Ref T4809. This saves us a few round trips to find a Buildable, and generally makes the notion of "active" more explicit (i.e., not just the diff with the largest ID). In the future, we may let you revert to previous diffs, which would make the "largest number" rule not always correct.

Test Plan

Ran differential.query, got sensible results.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20881.Apr 17 2014, 4:06 PM

epriestley retitled this revision from to Add `activeDiffPHID` to differential.query.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4809: Make "arc land" complain if builds are still executing or have failed.

Herald added a subscriber: epriestley.Apr 17 2014, 4:06 PM

btrahan accepted this revision.Apr 17 2014, 6:32 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 17 2014, 6:32 PM

Closed by commit rP62973e0f5396 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

conduit/

ConduitAPI_differential_query_Method.php

1 line

Diff 20897

src/applications/differential/conduit/ConduitAPI_differential_query_Method.php

Loading...