Paths

Table of Contentst

Differential D8796

Drop nonsense buildStatus field from Buildable
ClosedPublic
Actions

Authored by epriestley on Apr 16 2014, 10:35 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T1049: Implement Harbormaster
T4809: Make "arc land" complain if builds are still executing or have failed

Commits

Restricted Diffusion Commit
rP4918773afe35: Drop nonsense buildStatus field from Buildable

Summary

Ref T4809. Buildables currently have buildStatus and buildableStatus. Neither are used, and no one knows why we have two.

I'm going to use buildableStatus shortly, but buildStatus is meaningless; burn it.

Test Plan

grep, examined similar get/set calls, created a new buildable, ran storage upgrade.

Diff Detail

Repository

rP Phabricator

Branch

hm3

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

epriestley updated this revision to Diff 20872.Apr 16 2014, 10:35 PM

epriestley retitled this revision from to Drop nonsense buildStatus field from Buildable.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4809: Make "arc land" complain if builds are still executing or have failed.

Herald added a subscriber: epriestley.Apr 16 2014, 10:35 PM

btrahan accepted this revision.Apr 17 2014, 6:24 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 17 2014, 6:24 PM

Closed by commit rP4918773afe35 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20140416.harbor.1.sql

2 lines

src/

applications/

harbormaster/

storage/

HarbormasterBuildable.php

2 lines

Diff 20872

View Options

resources/sql/autopatches/20140416.harbor.1.sql