Differential D8781

Make discovery slightly cheaper in the common case
ClosedPublic
Actions

Authored by epriestley on Apr 15 2014, 11:23 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T4605: Improve responsiveness of repository tracking for large numbers of repositories

Commits

Restricted Diffusion Commit
rP417056932e62: Make discovery slightly cheaper in the common case

Summary

Ref T4605. Before discovering branches, try to prefill the cache in bulk. For repositories with large numbers of branches, this allows us to issue dramatically fewer queries.

(Before D8780, this cache was usually held across discovery events, so being able to fill it cheaply was not as relevant.)

Test Plan

Ran discovery on Git, Mercurial and SVN repositories. Observed fewer queries for Git/Mercurial.

Diff Detail

Repository

rP Phabricator

Branch

pull2

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

epriestley updated this revision to Diff 20839.Apr 15 2014, 11:23 PM

epriestley retitled this revision from to Make discovery slightly cheaper in the common case.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley.Apr 15 2014, 11:23 PM

epriestley updated this object.Apr 16 2014, 1:59 AM

epriestley added a task: T4605: Improve responsiveness of repository tracking for large numbers of repositories.

btrahan accepted this revision.Apr 16 2014, 6:06 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 16 2014, 6:06 PM

Closed by commit rP417056932e62 (authored by @epriestley).

epriestley mentioned this in T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT".Jan 22 2021, 8:23 PM

epriestley mentioned this in D21513: Correct the behavior of "bin/repository discover --repair".Jan 22 2021, 8:25 PM

epriestley mentioned this in rP16a14af2bb17: Correct the behavior of "bin/repository discover --repair".Jan 23 2021, 3:51 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

engine/

PhabricatorRepositoryDiscoveryEngine.php

28 lines

Diff 20839

View Options

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

Make discovery slightly cheaper in the common caseClosedPublicActions