Page MenuHomePhabricator

Fix a lookup issue in Owners
ClosedPublic

Authored by epriestley on Apr 15 2014, 6:09 PM.
Tags
None
Referenced Files
F20877585: D8779.id20835.diff
Fri, Jun 26, 12:00 PM
F20877526: D8779.id20834.diff
Fri, Jun 26, 11:59 AM
F20877129: D8779.diff
Fri, Jun 26, 11:53 AM
Unknown Object (File)
Tue, Jun 23, 11:07 AM
Unknown Object (File)
Sat, Jun 6, 8:06 AM
Unknown Object (File)
Sat, Jun 6, 7:56 AM
Unknown Object (File)
Feb 7 2026, 8:29 PM
Unknown Object (File)
Dec 24 2025, 5:45 PM
Subscribers

Details

Summary

Fixes T4477. Sort of winging this but it's probably the right fix?

One error in T4477.

One error via email:

[2014-04-15 17:44:34] ERROR 8: Undefined index: /some_index/ at [/phab_path/phabricator/src/applications/owners/storage/PhabricatorOwnersPackage.php:213]
  #0 PhabricatorOwnersPackage::findLongestPathsPerPackage(Array of size 3 starting with: { 0 => Array of size 3 starting with: { id => 5 } }, Array of size 8 starting with: { / => Array of size 2 starting with: { /some_index/some_file.py => true } }) called at [/phab_path/phabricator/src/applications/owners/storage/PhabricatorOwnersPackage.php:170]
  #1 PhabricatorOwnersPackage::loadPackagesForPaths(Object PhabricatorRepository, Array of size 2 starting with: { 0 => /some_index/some_file.py }) called at [/phab_path/phabricator/src/applications/owners/storage/PhabricatorOwnersPackage.php:119]
...
Test Plan

Will make @zeeg do it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix a lookup issue in Owners.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a subscriber: zeeg.
btrahan edited edge metadata.

makes sense to me

This revision is now accepted and ready to land.Apr 15 2014, 6:10 PM
epriestley updated this revision to Diff 20835.

Closed by commit rP20abf37b88cd (authored by @epriestley).