Page MenuHomePhabricator

Fix a lookup issue in Owners
ClosedPublic

Authored by epriestley on Apr 15 2014, 6:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 2:52 PM
Unknown Object (File)
Sat, Dec 7, 11:11 AM
Unknown Object (File)
Fri, Dec 6, 6:28 PM
Unknown Object (File)
Sat, Nov 30, 6:24 PM
Unknown Object (File)
Fri, Nov 29, 7:51 PM
Unknown Object (File)
Fri, Nov 29, 7:51 PM
Unknown Object (File)
Fri, Nov 29, 7:51 PM
Unknown Object (File)
Wed, Nov 27, 2:41 PM
Subscribers

Details

Summary

Fixes T4477. Sort of winging this but it's probably the right fix?

One error in T4477.

One error via email:

[2014-04-15 17:44:34] ERROR 8: Undefined index: /some_index/ at [/phab_path/phabricator/src/applications/owners/storage/PhabricatorOwnersPackage.php:213]
  #0 PhabricatorOwnersPackage::findLongestPathsPerPackage(Array of size 3 starting with: { 0 => Array of size 3 starting with: { id => 5 } }, Array of size 8 starting with: { / => Array of size 2 starting with: { /some_index/some_file.py => true } }) called at [/phab_path/phabricator/src/applications/owners/storage/PhabricatorOwnersPackage.php:170]
  #1 PhabricatorOwnersPackage::loadPackagesForPaths(Object PhabricatorRepository, Array of size 2 starting with: { 0 => /some_index/some_file.py }) called at [/phab_path/phabricator/src/applications/owners/storage/PhabricatorOwnersPackage.php:119]
...
Test Plan

Will make @zeeg do it.

Diff Detail

Repository
rP Phabricator
Branch
package1
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley retitled this revision from to Fix a lookup issue in Owners.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a subscriber: zeeg.
btrahan edited edge metadata.

makes sense to me

This revision is now accepted and ready to land.Apr 15 2014, 6:10 PM
epriestley updated this revision to Diff 20835.

Closed by commit rP20abf37b88cd (authored by @epriestley).