Arcanist - fix shouldAmend code
ClosedPublic
Actions

Authored by btrahan on Apr 11 2014, 8:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jul 1, 1:41 PM

	Unknown Object (File)
	Tue, Jun 23, 11:06 AM

	Unknown Object (File)
	Tue, Jun 23, 11:06 AM

	Unknown Object (File)
	Tue, Jun 23, 11:06 AM

	Unknown Object (File)
	Mar 7 2026, 3:31 PM

	Unknown Object (File)
	Mar 5 2026, 5:10 AM

	Unknown Object (File)
	Feb 10 2026, 7:11 PM

	Unknown Object (File)
	Jan 18 2026, 6:59 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley
shadowhand

Commits

rARC43792895a679: Arcanist - fix shouldAmend code

Summary

make it a real member variable. See rARC77a9c1814063 and D8753#33914.

Test Plan

sending up this diff!

Diff Detail

Repository

rARC Arcanist

Branch

fixboooooo

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

btrahan updated this revision to Diff 20779.Apr 11 2014, 8:07 PM

btrahan retitled this revision from to Arcanist - fix shouldAmend code.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, shadowhand.

Herald added subscribers: Korvin, epriestley.Apr 11 2014, 8:07 PM

epriestley accepted this revision.Apr 11 2014, 8:07 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 11 2014, 8:07 PM

Closed by commit rARC43792895a679 (authored by @btrahan).

Makes more sense now. Thanks. :)

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistBaseWorkflow.php

12 lines

Diff 20779

View Options

src/workflow/ArcanistBaseWorkflow.php

Arcanist - fix shouldAmend codeClosedPublicActions