Page MenuHomePhabricator

OAuth - add a little notes section for admins to remember details about external accounts
ClosedPublic

Authored by btrahan on Apr 8 2014, 11:06 PM.
Tags
None
Referenced Files
F14398802: D8726.diff
Sun, Dec 22, 2:54 PM
Unknown Object (File)
Tue, Dec 17, 10:59 AM
Unknown Object (File)
Tue, Dec 17, 3:24 AM
Unknown Object (File)
Thu, Dec 12, 10:55 PM
Unknown Object (File)
Wed, Dec 11, 11:03 PM
Unknown Object (File)
Tue, Dec 10, 6:38 PM
Unknown Object (File)
Sat, Dec 7, 3:04 AM
Unknown Object (File)
Nov 21 2024, 8:35 AM
Subscribers

Details

Summary

Fixes T4755. This also includes putting in a note that Google might ToS you to use the Google+ API. Lots of code here as there was some repeated stuff between OAuth1 and OAuth2 so I made a base OAuth with less-base OAuth1 and OAuth2 inheriting from it. The JIRA provider remains an independent mess and didn't get the notes field thing.

Test Plan

looked at providers and read pretty instructions.

Diff Detail

Repository
rP Phabricator
Branch
T4755
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

btrahan retitled this revision from to OAuth - add a little notes section for admins to remember details about external accounts.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

This all makes sense to me. JIRA should definitely remain in its own special little world.

This revision is now accepted and ready to land.Apr 8 2014, 11:16 PM
btrahan updated this revision to Diff 20715.

Closed by commit rP2d43cf12964d (authored by @btrahan).