Page MenuHomePhabricator

Add an optional "notes" field to OAuth providers
Closed, ResolvedPublic

Description

With OAuth providers like Google, Facebook and Disqus, it's very easy to lose track of whose account an application is registered under. Having an optional, human-readable notes field with a suggestion like "keep track of whose account this thing is on here" could be helpful.

epriestley: Maybe we should have an optional human-readable field on that UI like "Whose account is this thing under?". :P
balpert: "Maybe we should have an optional human-readable field on that UI like 'Whose account is this thing under?'" <-- yes please

This will teach me to make jokes, etc etc etc etc

Event Timeline

epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Auth.
epriestley added subscribers: epriestley, sophiebits.
  • Add an optional "notes" sort of field to OAuth provider configuration and encourage administrators to record details about which account external applications are registered under.
  • This UI is in Auth (Application) -> (Google/Facebook/etc)
  • PhabricatorAuthProviderOAuth::extendEditForm() is probably a good place to start looking.
  • Update the help text for these providers (for example, PhabricatorAuthProviderOAuthGoogle::getConfigurationHelp()) to suggest recording who owns the account.
  • For the Google provider, register a new account and run through the workflow in this ticket (https://github.com/facebook/phabricator/issues/565) and update the instructions accordingly if there are new screens we're missing.

For the Google provider, I got a "check you agree" ToS dialogue, which was more light weight than what was reported in Github. I just did generic language about having to confirm terms of service.