Arcanist - allow amending revisions by other authors in the working copy
ClosedPublic
Actions

Authored by btrahan on Apr 7 2014, 7:04 PM.

Tags

None

Referenced Files

	F14840912: D8716.id20668.diff
	Sat, Feb 1, 10:50 AM

	Unknown Object (File)
	Sat, Feb 1, 1:51 AM

	Unknown Object (File)
	Sat, Jan 25, 6:20 PM

	Unknown Object (File)
	Sat, Jan 25, 3:00 AM

	Unknown Object (File)
	Fri, Jan 24, 6:54 AM

	Unknown Object (File)
	Mon, Jan 20, 12:28 PM

	Unknown Object (File)
	Sat, Jan 18, 4:33 PM

	Unknown Object (File)
	Sat, Jan 18, 4:20 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T4670: When we identify working copy revisions, we should annotate unowned revisions, not exclude them

Commits

rARC2714395d986c: Arcanist - allow amending revisions by other authors in the working copy

Summary

Fixes T4670. Give the user an option to abort but otherwise proceed.

Test Plan

arc patch D8685 (by epriestley); arc amend

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 20668.Apr 7 2014, 7:04 PM

btrahan added a task: T4670: When we identify working copy revisions, we should annotate unowned revisions, not exclude them.

btrahan retitled this revision from to Arcanist - allow amending revisions by other authors in the working copy.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley.Apr 7 2014, 7:04 PM

epriestley accepted this revision.Apr 8 2014, 2:56 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 8 2014, 2:56 AM

Closed by commit rARC2714395d986c (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistAmendWorkflow.php

19 lines

Diff 20690

View Options

src/workflow/ArcanistAmendWorkflow.php

Arcanist - allow amending revisions by other authors in the working copyClosedPublicActions