Page MenuHomePhabricator
Differential D8706

Diffusion - Warn users to explicitly provide PATH for SVN hosted repositories
ClosedPublic
Actions

Authored by btrahan on Apr 4 2014, 7:22 PM.
Tags
None
Referenced Files
F13129832: D8706.diff
Wed, May 1, 3:20 AM
Unknown Object (File)
Mon, Apr 29, 7:55 PM
Unknown Object (File)
Sun, Apr 28, 12:12 PM
Unknown Object (File)
Sun, Apr 28, 12:12 PM
Unknown Object (File)
Sun, Apr 28, 12:12 PM
Unknown Object (File)
Sun, Apr 28, 12:12 PM
Unknown Object (File)
Thu, Apr 25, 1:21 AM
Unknown Object (File)
Wed, Apr 24, 10:57 PM
View All Files
Subscribers
• awoz
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T4547: Warn users about explicitly providing PATH for SVN hosted repositories
Commits
Restricted Diffusion Commit
rPc408168c2500: Diffusion - Warn users to explicitly provide PATH for SVN hosted repositories
Summary

Fixes T4547.

Test Plan

saw the warning, looked good

Diff Detail

Repository
rP Phabricator
Branch
T4547
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

btrahan updated this revision to Diff 20647.Apr 4 2014, 7:22 PM
btrahan added a task: T4547: Warn users about explicitly providing PATH for SVN hosted repositories.
btrahan retitled this revision from to Diffusion - Warn users to explicitly provide PATH for SVN hosted repositories.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley.Apr 4 2014, 7:22 PM
btrahan added a comment.Apr 4 2014, 7:22 PM

Screen_Shot_2014-04-04_at_12.22.17_PM.png (1×1 px, 556 KB)

epriestley accepted this revision.Apr 4 2014, 7:35 PM
epriestley edited edge metadata.

One possible refinement/simplification inline, although it will probably never matter in practice.

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
777

Filesystem::isDescendant() might be slightly more correct than a straight path comparison, and cover some cases involving symlinks.

This revision is now accepted and ready to land.Apr 4 2014, 7:35 PM
btrahan updated this revision to Diff 20650.Apr 4 2014, 7:47 PM
btrahan edited edge metadata.

use Filesystem::isDescendant instead!

btrahan closed this revision.Apr 4 2014, 7:47 PM
btrahan updated this revision to Diff 20651.

Closed by commit rPc408168c2500 (authored by @btrahan).

• awoz added a subscriber: • awoz.Aug 3 2015, 9:25 PM

The solution in the warning message may be misleading especially if subversion-client is _not_ installed.

My solution to the warning was to install subversion allowing the default PATH to find the svn binary.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
47 lines

Diff 20647

View Options

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php

Loading...
Phabricator · Built by Phacility