Differential D8705

Audit - add ability to add a package as an auditor
ClosedPublic
Actions

Authored by btrahan on Apr 4 2014, 6:56 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T4687: "Add Auditors" action in Diffusion/Audit does not accept projects

Commits

Restricted Diffusion Commit
rPf67a853fe7cc: Audit - add ability to add a package as an auditor

Summary

Fixes T4687. This was also pretty easy...!

Test Plan

made a package with a test user as owner. added package as owner. looked right on commit page. logged in as test user and verified audit showed up on home page.

Diff Detail

Repository

rP Phabricator

Branch

T4687

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

btrahan updated this revision to Diff 20646.Apr 4 2014, 6:56 PM

btrahan added a task: T4687: "Add Auditors" action in Diffusion/Audit does not accept projects.

btrahan retitled this revision from to Audit - add ability to add a package as an auditor.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley.Apr 4 2014, 6:56 PM

Screen_Shot_2014-04-04_at_11.55.23_AM.png (1×2 px, 645 KB)

btrahan added a subscriber: chad.Apr 4 2014, 7:00 PM

btrahan added inline comments.

src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php
317	oh, this should be something better @chad - can we get the "package" application icon as a "status" icon?

I also want to make the project icon customizable, so it's not always "briefcase" -- not sure if we have icons already, but "group of people" and "tag" would be good options at a minimum, and then maybe a "milestone marker", "sprinting silhouette", and some ZANY icons. These might already exist.

This revision is now accepted and ready to land.Apr 4 2014, 7:14 PM