Page MenuHomePhabricator
Differential D8664

Allow administrators to edit System Agent information from the agent's profile
ClosedPublic
Actions

Authored by epriestley on Apr 1 2014, 11:02 PM.
Tags
None
Referenced Files
F15453804: D8664.id.diff
Sat, Mar 29, 2:29 PM
F15444872: D8664.diff
Thu, Mar 27, 11:39 AM
F15427274: D8664.id20551.diff
Sun, Mar 23, 1:30 PM
F15402545: D8664.id.diff
Mon, Mar 17, 10:58 PM
F15398650: D8664.id20577.diff
Mon, Mar 17, 1:05 AM
F15343784: D8664.diff
Mon, Mar 10, 12:56 AM
Unknown Object (File)
Sun, Mar 2, 5:19 AM
Unknown Object (File)
Sun, Mar 2, 5:19 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4065: Allow administration of VCS password and SSH keys for System Agents
Commits
Restricted Diffusion Commit
rPb6b2e65511f5: Allow administrators to edit System Agent information from the agent's profile
Summary

Ref T4065. Currently, we have this super copy/pasted "edit profile picture" UI for system agents.

Instead, give administrators direct access from profiles, so they can use the same code pages do.

Test Plan

Edited my profile picture and profile details. Edited an agent's. Was unable to edit a non-agent user.

Diff Detail

Repository
rP Phabricator
Branch
user3
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Diff 20551.Apr 1 2014, 11:02 PM
epriestley retitled this revision from to Allow administrators to edit System Agent information from the agent's profile.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4065: Allow administration of VCS password and SSH keys for System Agents.
Herald added a subscriber: epriestley.Apr 1 2014, 11:02 PM
btrahan accepted this revision.Apr 2 2014, 12:03 AM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 2 2014, 12:03 AM
epriestley closed this revision.Apr 2 2014, 7:05 PM
epriestley updated this revision to Diff 20577.

Closed by commit rPb6b2e65511f5 (authored by @epriestley).

Revision Contents
Changeset List

Diff 20551

View Options

src/applications/people/controller/PhabricatorPeopleEditController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileEditController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfilePictureController.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
Phabricator · Built by Phacility