Fix help menu links for folks with diviner uninstalled
ClosedPublic
Actions

Authored by btrahan on Mar 28 2014, 8:38 PM.

Tags

None

Referenced Files

	F14410952: D8638.diff
	Tue, Dec 24, 8:25 AM

	Unknown Object (File)
	Fri, Dec 6, 12:13 AM

	Unknown Object (File)
	Tue, Dec 3, 3:03 AM

	Unknown Object (File)
	Fri, Nov 29, 3:54 AM

	Unknown Object (File)
	Fri, Nov 29, 3:54 AM

	Unknown Object (File)
	Fri, Nov 29, 3:49 AM

	Unknown Object (File)
	Fri, Nov 29, 3:43 AM

	Unknown Object (File)
	Nov 21 2024, 7:47 PM

View All Files

Subscribers

epriestley

Korvin

Tokens

"Grey Medal" token, awarded by bluehawk."Like" token, awarded by epriestley.

Details

Reviewers

epriestley

Maniphest Tasks

T4690: "Help" menu bubbles not appearing in applications if Diviner is uninstalled

Commits

Restricted Diffusion Commit
rP44942f3378a9: Fix help menu links for folks with diviner uninstalled

Summary

move code to uninstallable help app rather than diviner. Fixes T4690.

Test Plan

uninstalled diviner, noted no links, then moved the code and suddenly helpful help links showed up once more.

Diff Detail

Repository

rP Phabricator

Branch

T4690

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

btrahan updated this revision to Diff 20483.Mar 28 2014, 8:38 PM

btrahan added a task: T4690: "Help" menu bubbles not appearing in applications if Diviner is uninstalled.

btrahan retitled this revision from to Fix help menu links for folks with diviner uninstalled.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley.Mar 28 2014, 8:38 PM

epriestley accepted this revision.Mar 28 2014, 8:40 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 28 2014, 8:40 PM

Closed by commit rP44942f3378a9 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

diviner/

application/

PhabricatorApplicationDiviner.php

25 lines

help/

application/

PhabricatorApplicationHelp.php

24 lines

Diff 20483

View Options

src/applications/diviner/application/PhabricatorApplicationDiviner.php