Page MenuHomePhabricator
Differential D8636

Rename project -> product on edit/create UIs
ClosedPublic
Actions

Authored by epriestley on Mar 28 2014, 1:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 29, 7:09 PM
Unknown Object (File)
Sat, Dec 28, 3:48 AM
Unknown Object (File)
Sat, Dec 28, 3:48 AM
Unknown Object (File)
Sat, Dec 28, 3:48 AM
Unknown Object (File)
Thu, Dec 26, 12:07 AM
Unknown Object (File)
Sun, Dec 22, 2:25 AM
Unknown Object (File)
Tue, Dec 10, 5:12 AM
Unknown Object (File)
Mon, Dec 9, 4:05 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T3092: Responsively design Releeph
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP8c88180ee19c: Rename project -> product on edit/create UIs
Summary

Ref T3092. Ref T3549. Modernize the product creation and edit UIs and make them say "product" instead of "project".

Test Plan
  • Created products.
  • Edited products.

Diff Detail

Repository
rP Phabricator
Branch
rel8
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

epriestley updated this revision to Diff 20477.Mar 28 2014, 1:32 PM
epriestley retitled this revision from to Rename project -> product on edit/create UIs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: Restricted Maniphest Task, T3092: Responsively design Releeph.
Herald added a subscriber: epriestley.Mar 28 2014, 1:32 PM
epriestley updated this revision to Diff 20478.Mar 28 2014, 1:33 PM
  • Mark the edit page as device-ready now.
btrahan accepted this revision.Mar 28 2014, 8:22 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/releeph/controller/project/ReleephProductEditController.php
239–240

outside this diff but i'd be verbose and repeat the "associated with..." bit.

This revision is now accepted and ready to land.Mar 28 2014, 8:22 PM
epriestley added inline comments.Mar 28 2014, 8:25 PM
src/applications/releeph/controller/project/ReleephProductEditController.php
239–240

Yeah, this form has a lot of issues in general. Agreed on this specifically.

epriestley closed this revision.Mar 29 2014, 4:16 PM
epriestley updated this revision to Diff 20498.

Closed by commit rP8c88180ee19c (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
8 lines
applications/
releeph/
application/
4 lines
controller/
project/
ReleephProductCreateController.php
ReleephProjectCreateController.php
27 lines
ReleephProductEditController.php
ReleephProjectEditController.php
161 lines

Diff 20478

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/releeph/application/PhabricatorApplicationReleeph.php

Loading...
View Options

src/applications/releeph/controller/project/ReleephProductCreateController.php

Loading...
View Options

src/applications/releeph/controller/project/ReleephProductEditController.php

Loading...
View Options

src/applications/releeph/controller/project/ReleephProjectCreateController.php

Loading...
View Options

src/applications/releeph/controller/project/ReleephProjectEditController.php

Loading...
Phabricator · Built by Phacility